Re: [PATCH v1] pinctrl: intel: Allow to request locked pins

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Andy,

On Fri, Jul 26, 2019 at 10:08 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Some firmwares would like to protect pins from being modified by OS
> and at the same time provide them to OS as a resource. So, the driver
> in such circumstances may request pin and may not change its state.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Interesting patch!

> +enum {
> +       PAD_UNLOCKED    = 0,
> +       PAD_LOCKED      = 1,
> +       PAD_LOCKED_TX   = 2,
> +       PAD_LOCKED_FULL = PAD_LOCKED | PAD_LOCKED_TX,
> +};

Please add some kerneldoc explaining what these different lock
states are. My head is spinning. Locked? Locked TX? Locked full?

Yours,
Linus Walleij