Re: [PATCH] gpio: of: Break out OF-only code

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Jul 16, 2019 at 02:39:18PM +0200, Linus Walleij wrote:
> The core gpiolib should not contain any OF/device tree-only
> code. Try to break out the main part of it and push it down
> into the optional gpiolib-of.c part of the library.
> 
> Create a local gpiolib-of.h header and move stuff around a
> bit to get a clean cut.

Good one!
One question below, though.

>  drivers/gpio/gpiolib-of.c | 114 ++++++++++++++++++++++++++++++++++++++
>  drivers/gpio/gpiolib.c    | 113 +++----------------------------------
>  drivers/gpio/gpiolib.h    |  27 ---------
>  3 files changed, 122 insertions(+), 132 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 2bc0bcd7a410..00ed60304cd4 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -21,6 +21,34 @@
>  #include <linux/gpio/machine.h>
>  
>  #include "gpiolib.h"
> +#include "gpiolib-of.h"

Did I miss something? Where is the file?

-- 
With Best Regards,
Andy Shevchenko