On 08/07/2019 08:04, Linus Walleij wrote: > On Wed, Jun 26, 2019 at 3:43 PM Jon Hunter <jonathanh@xxxxxxxxxx> wrote: > >> The function tegra_gpio_debuginit() just calls debugfs_create_file() >> and given that there is already a stub function implemented for >> debugfs_create_file() when CONFIG_DEBUG_FS is not enabled, there is >> no need for the function tegra_gpio_debuginit() and so remove it. >> >> Finally, use a space and not a tab between the #ifdef and >> CONFIG_DEBUG_FS. >> >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > > Sadly I've had to revert this commit because of build errors, but > let's see if we can figure it out after the merge window. Sorry about that. I will be more thorough in future. Jon -- nvpublic