Hi Neil, On Mon, Jul 1, 2019 at 11:13 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > In order to protect clock measuring when multiple process asks for > a measure, protect the main measure function with mutexes. > > Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx> > Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > --- > drivers/soc/amlogic/meson-clk-measure.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/meson-clk-measure.c > index 19d4cbc93a17..c470e24f1dfa 100644 > --- a/drivers/soc/amlogic/meson-clk-measure.c > +++ b/drivers/soc/amlogic/meson-clk-measure.c > @@ -11,6 +11,8 @@ > #include <linux/debugfs.h> > #include <linux/regmap.h> > > +static DEFINE_MUTEX(measure_lock); I wonder if that should be part of struct meson_msr for consistency reasons apart from that: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>