On Fri, Jun 21, 2019 at 5:24 PM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > When a GPIO controller registers a pin range with a pin controller, > establish a device link between them in order to keep track of the > dependency, which will help keep the right suspend/resume ordering. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> This make sense. > + link = device_link_add(range->gc->parent, pctldev->dev, > + DL_FLAG_AUTOREMOVE_CONSUMER); What about parentless GPIO chips now again? The parent field is optional, sad to say (yes I wish I could just fix it all). > + device_link_remove(range->gc->parent, pctldev->dev); And here again. Yours, Linus Walleij