Hi Andrew, On 18/06/19 5:09 AM, Andrew Lunn wrote: > On Mon, Jun 17, 2019 at 10:04:30PM +1200, Chris Packham wrote: >> Add compatible string for the core clock on the 98dx1135 switch with >> integrated CPU. > > Hi Chris > > Should there be a list of provider IDs and clock names? > That list would be the same as the Kirkwood/Dove. I thought about adding it but decided not to to avoid unnecessary duplication. One compromise would be to change "for 98dx1135 SoC core clocks" to "for Kirkwood 98dx1135 SoC" which would fit with the MV88f6180 line above and make it clear that it falls into the kirkwood bucket.