Hi Martin! Thanks for fixing this up! A hint for a follow-up: On Wed, Jun 12, 2019 at 9:31 PM Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 4335bd771ce5..816edb545592 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -97,7 +97,7 @@ struct stmmac_mdio_bus_data { > int *irqs; > int probed_phy_irq; > #ifdef CONFIG_OF > - int reset_gpio, active_low; > + int reset_gpio; Nothing in the kernel seems to be using this reset_gpio either. I think it can be deleted with associated code, any new users should use machine descriptors if they insist on board files. Yours, Linus Walleij