Re: [PATCH v3 1/1] pinctlr: mcp23s08: Fix add_data and irqchip_add_nested call order

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Jun 13, 2019 at 6:10 AM Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote:

> Currently probing of the mcp23s08 results in an error message
> "detected irqchip that is shared with multiple gpiochips:
> please fix the driver"
>
> This is due to the following:
>
> Call to mcp23s08_irqchip_setup() with call hierarchy:
> mcp23s08_irqchip_setup()
>   gpiochip_irqchip_add_nested()
>     gpiochip_irqchip_add_key()
>       gpiochip_set_irq_hooks()
>
> Call to devm_gpiochip_add_data() with call hierarchy:
> devm_gpiochip_add_data()
>   gpiochip_add_data_with_key()
>     gpiochip_add_irqchip()
>       gpiochip_set_irq_hooks()
>
> The gpiochip_add_irqchip() returns immediately if there isn't a irqchip
> but we added a irqchip due to the previous mcp23s08_irqchip_setup()
> call. So it calls gpiochip_set_irq_hooks() a second time.
>
> Fix this by moving the call to devm_gpiochip_add_data before
> the call to mcp23s08_irqchip_setup
>
> Fixes: 02e389e63 ("pinctrl: mcp23s08: fix irq setup order")
> Suggested-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij