Re: [PATCH V1 1/2] gpio: inverter: Add virtual controller for gpio configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.06.19 23:58, Linus Walleij wrote:

> For devicetree people mostly use the device tree cell flag
> GPIO_ACTIVE_LOW on these to work around it. But there
> are some cases where that isn't very readable.

hmm, do you recall any such case where it isn't reliable ?
What are the problems here ?

Personally, I've never had any problems yet. And already had a bunch of
cases where the gpio lines had been used by other drivers, eg. relais
via LED subsystem (yeah, not really semantically correct, but we don't
have an ralais subsystem yet ;-) or gpio-inputs, in opening contact
circuits where logical 1 means electrical 0. Whether the new inverter
device or good old GPIO_ACTIVE_LOW should be used here could easily
turn into a long philosophical debate ;-)

Perhaps the inverter driver could be the winner when variable/replacable
peripherals and oftree overlays.

Are there any plans for removing the GPIO_ACTIVE_LOW ?


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux