Re: [PATCH V1 1/2] gpio: inverter: Add virtual controller for gpio configuration

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Harish,

On Wed, Jun 12, 2019 at 9:57 AM Harish Jenny K N
<harish_kandiga@xxxxxxxxxx> wrote:
> Provides a new virtual gpio controller to configure the polarity
> of the gpio pins used by the userspace. When there is no kernel
> driver using the gpio pin, it becomes necessary for the userspace
> to configure the polarity of the gpio pin.
> This driver enables the userspace to directly use the gpio pin
> without worrying about the hardware level polarity configuration.
> Polarity configuration will be done by the virtual gpio controller
> based on device tree information
>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani_vivekanandan@xxxxxxxxxx>
> Signed-off-by: Harish Jenny K N <harish_kandiga@xxxxxxxxxx>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/gpio/gpio-inverter.c
> @@ -0,0 +1,144 @@

> +struct gpio_inverter {
> +       struct gpio_chip gpiochip;
> +       int count;
> +       struct gpio_desc *gpios[0];

Please use [] instead of [0] for denoting a flexible array, else
gcc will not warn when it is no longer at the end of the struct.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds