On 12/06/2019 20:32, Enrico Weigelt, metux IT consult wrote:
+#include <linux/gpio.h>
This is a legacy header.
You probably want to include <linux/gpio/driver.h>
Just counted 754 cases of such includes, 289 in arch, 345 in drivers.
Shall them be replaced ? Or is the new include only meant for gpio
*drivers* ?
G'day Enrico,
Yes they should all be replaced at some stage. from the header in question:
* <linux/gpio.h>
*
* This is the LEGACY GPIO bulk include file, including legacy APIs. It is
* used for GPIO drivers still referencing the global GPIO numberspace,
* and should not be included in new code.
*
* If you're implementing a GPIO driver, only include <linux/gpio/driver.h>
* If you're implementing a GPIO consumer, only include <linux/gpio/consumer.h>
--
Regards
Phil Reid