On Mon, Jun 10, 2019 at 11:50 AM Phil Reid <preid@xxxxxxxxxxxxxxxxx> wrote: > Keeping the irq_chip definition static shares it with multiple instances > of the altera gpiochip in the system. This is bad and now we get this > warning from gpiolib core: > > "detected irqchip that is shared with multiple gpiochips: please fix the > driver." > > Hence, move the irq_chip definition from being driver static into the > struct altera_gpio_chips. So a unique irq_chip is used for each gpiochip > instance. > > Signed-off-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx> Patch applied. Yours, Linus Walleij
Re: [PATCH 1/1] gpio: altera: Allocate irq_chip dynamically
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/1] gpio: altera: Allocate irq_chip dynamically
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Mon, 10 Jun 2019 16:24:58 +0200
- In-reply-to: <1560160211-12748-1-git-send-email-preid@electromag.com.au>
- References: <1560160211-12748-1-git-send-email-preid@electromag.com.au>
- References:
- [PATCH 1/1] gpio: altera: Allocate irq_chip dynamically
- From: Phil Reid
- [PATCH 1/1] gpio: altera: Allocate irq_chip dynamically
- Prev by Date: Re: [PATCH v3] gpio: xilinx: convert from OF GPIO to standard devm APIs
- Next by Date: Re: [PATCH] pinctrl: qcom: Clear status bit on irq_unmask
- Previous by thread: [PATCH 1/1] gpio: altera: Allocate irq_chip dynamically
- Index(es):
 |