Re: [PATCH] RFC: fmc: Try to convert to GPIO descriptors

[Federico Vaga <federico.vaga@xxxxxxx>]

On Saturday, June 8, 2019 3:46:07 PM CEST Linus Walleij wrote:
> On Tue, Jun 4, 2019 at 8:42 AM Federico Vaga <federico.vaga@xxxxxxx> wrote:
> > I take this occasion to renovate my proposal
> > https://lkml.org/lkml/2018/10/29/534
> 
> Hm, it looks from your proposal like the FMC device core
> is using its own hacks for i2c mastering, FPGA management
> and irqchips. Does it also have its own GPIO implementation
> not using struct gpio_chip from <linux/gpio/driver.h>?

The FMC subsystem has its own API for all those things.

> In that case my first step should rather be to remove the
> reference to <linux/gpio.h> because then FMC is not really
> using the GPIO subsystem.

No it is not. Probably you can safely remove it.

> As for the proposal so remove it, I'd like to hear what
> Alessandro says. If there is consensus on deleting this
> I can queue something up and send it to Torvalds, but
> I need consent from everyone who cares.
>
> Yours,
> Linus Walleij


-- 
Federico Vaga [CERN BE-CO-HT]