pinctrl: mcp23s08: detected irqchip that is shared with multiple gpiochips - real of false?

[Phil Reid <preid@xxxxxxxxxxxxxxxxx>]

G'day All,

Using kernel 5.1 I'm getting the following message:
"detected irqchip that is shared with multiple gpiochips: please fix the driver"

Which I believe should be fixed by:
19ab5ca "pinctrl: mcp23s08: Allocate irq_chip dynamic"

However mcp23s08_probe_one() ends up calling gpiochip_set_irq_hooks() twice.
Once from

[    1.482385] [<8049da44>] (gpiochip_set_irq_hooks) from [<8049781c>] (gpiochip_irqchip_add_key+0x134/0x140)
[    1.482394]  r5:ef1e8bf0 r4:ee74f074
[    1.482409] [<804976e8>] (gpiochip_irqchip_add_key) from [<8049640c>] (mcp23s08_probe_one.constprop.0+0x4b0/0x6c0)
[    1.482424]  r9:00000020 r8:ee74f074 r7:80d09088 r6:ee74ec20 r5:ee74f160 r4:ee74f040
[    1.482438] [<80495f5c>] (mcp23s08_probe_one.constprop.0) from [<804966f4>] (mcp230xx_probe+0xd8/0x104)
[    1.482452]  r10:00000000 r9:80a31820 r8:ee74ec20 r7:eee6997c r6:80d09088 r5:ee74ec00
[    1.482458]  r4:ee74f040
[    1.482474] [<8049661c>] (mcp230xx_probe) from [<80607934>] (i2c_device_probe+0x290/0x2d4)

And then:
[    1.492123] [<8049da44>] (gpiochip_set_irq_hooks) from [<8049d904>] (gpiochip_add_data_with_key+0x988/0x9a8)
[    1.492132]  r5:ee74f074 r4:ef1e8bf0
[    1.492147] [<8049cf7c>] (gpiochip_add_data_with_key) from [<8049d978>] (devm_gpiochip_add_data+0x54/0x90)
[    1.492162]  r10:00000000 r9:00000020 r8:ee74f074 r7:ee74ec20 r6:ee74f074 r5:ee71a5c0
[    1.492169]  r4:ee74f040
[    1.492184] [<8049d924>] (devm_gpiochip_add_data) from [<80496194>] (mcp23s08_probe_one.constprop.0+0x238/0x6c0)
[    1.492195]  r7:80d09088 r6:ee74ec20 r5:00000000 r4:ee74f040
[    1.492209] [<80495f5c>] (mcp23s08_probe_one.constprop.0) from [<804966f4>] (mcp230xx_probe+0xd8/0x104)
[    1.492222]  r10:00000000 r9:80a31820 r8:ee74ec20 r7:eee6997c r6:80d09088 r5:ee74ec00
[    1.492229]  r4:ee74f040
[    1.492243] [<8049661c>] (mcp230xx_probe) from [<80607934>] (i2c_device_probe+0x290/0x2d4)

The first time is via:
mcp23s08_probe_one
mcp23s08_irqchip_setup - inlined
gpiochip_irqchip_add_nested - inlined
gpiochip_irqchip_add_key

So is the warning something that can be ignored or is something wrong happening.

I'm seeing this on a couple of other gpio drivers as well.



--
Regards
Phil Reid