On Wed, May 29, 2019 at 12:13:42PM +0200, Ard Biesheuvel wrote: > The ACPI GPIO OpRegion code never sets the direction for GPIOs that > it configures from scratch, leaving unconfigured GPIOs to be left > at the default direction, which is typically input not output. The code does: enum gpiod_flags flags = acpi_gpio_to_gpiod_flags(agpio); before it requests the GPIO. Isn't that sufficient?
Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Wed, 29 May 2019 13:27:47 +0300
- In-reply-to: <20190529101342.30673-1-ard.biesheuvel@linaro.org>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20190529101342.30673-1-ard.biesheuvel@linaro.org>
- User-agent: Mutt/1.11.4 (2019-03-13)
- Follow-Ups:
- Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- From: Ard Biesheuvel
- Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- References:
- [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- From: Ard Biesheuvel
- [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- Prev by Date: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- Next by Date: Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- Previous by thread: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- Next by thread: Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs
- Index(es):
 |