Re: [PATCH v2 0/4] sh-pfc: r8a7795/6/65: Add TPU pins, groups and functions

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, May 08, 2019 at 03:40:08PM +0200, Geert Uytterhoeven wrote:
> 	Hi Linus,
> 
> This patch series adds pins, groups and functions for the 16-Bit Timer
> Pulse Unit (TPU) outputs on the R-Car H3/M3-W/M3-N and RZ/G2M SoCs.
> 
> This has been tested on the Salvator-XS development board with R-Car
> M3-N.  As the TPU parts of the R-Car H3/M3-W and RZ/G2M SoCs are very
> similar, I expect this to work on those SoCs, too.
> 
> Changes compared to v1:
>   - Update .common[] array sizes in pfc-r8a7796.c.
> 
> I intend to queue this in sh-pfc-for-v5.3.
> 
> Test procedure:
>   - Apply Cao Van Dong's series "[PATCH v2 0/5] Add TPU support for R-Car
>     H3/M3-W/M3-N"
>     (https://lore.kernel.org/linux-renesas-soc/1556155517-5054-1-git-send-email-cv-dong@xxxxxxxxxxx/),
>   - Make sure switches SW31-[1-4] are switched off,
>   - Enable TPU and pin control in DTS:
> 
> 	--- a/arch/arm64/boot/dts/renesas/salvator-xs.dtsi
> 	+++ b/arch/arm64/boot/dts/renesas/salvator-xs.dtsi
> 	@@ -27,3 +27,18 @@
> 			clock-names = "xin";
> 		};
> 	 };
> 	+
> 	+&tpu {
> 	+       // SW31-[1-4] OFF
> 	+       pinctrl-0 = <&tpu_pins>;
> 	+       pinctrl-names = "default";
> 	+
> 	+       status = "okay";
> 	+};
> 	+
> 	+&pfc {
> 	+       tpu_pins: tpu {
> 	+               groups = "tpu_to2", "tpu_to3";
> 	+               function = "tpu";
> 	+       };
> 	+};
> 
>   - Exercise userspace PWM control for pwm[23] of
>     /sys/class/pwm/pwmchip1/,
>   - Inspect PWM signals on the input side of SW31-[12] using an
>     oscilloscope,
>   - Disable TPU and pin control in DTS, and restore SW31 switch
>     settings.
> 
> Thanks!
> 
> Geert Uytterhoeven (4):
>   pinctrl: sh-pfc: r8a7795-es1: Add TPU pins, groups and functions
>   pinctrl: sh-pfc: r8a7795: Add TPU pins, groups and functions
>   pinctrl: sh-pfc: r8a7796: Add TPU pins, groups and functions
>   pinctrl: sh-pfc: r8a77965: Add TPU pins, groups and functions

Thanks Geert,

for all patches:

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>