Re: [PATCH v1] arm64: dts: qcom: msm8998: Add i2c5 pins

[Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>]

On Thu 25 Apr 09:06 PDT 2019, Marc Gonzalez wrote:

> Downstream source:
> https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi?h=LE.UM.1.3.r3.25#n165
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> index 6db70acd38ee..d0a95c70d1e7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> @@ -2,6 +2,13 @@
>  /* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
>  
>  &tlmm {
> +	i2c5_default: i2c5_default {

You need to reference this node for it to make a difference. Also the
drive-strength and bias are board specific, so please move this to your
board dts (and reference the node).

Regards,
Bjorn

> +		pins = "gpio87", "gpio88";
> +		function = "blsp_i2c5";
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +
>  	sdc2_clk_on: sdc2_clk_on {
>  		config {
>  			pins = "sdc2_clk";
> -- 
> 2.17.1