Re: [PATCH 1/4] pinctrl: sh-pfc: Correct printk level of group referral warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2019 at 11:55:39AM +0200, Geert Uytterhoeven wrote:
> Fixes: 6161b39a14380815 ("pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

This looks good to me

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>

But I do wonder if "referred" should be "referenced"

> ---
>  drivers/pinctrl/sh-pfc/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
> index 3f989f5cb021ecbc..18d7f6d9402093d4 100644
> --- a/drivers/pinctrl/sh-pfc/core.c
> +++ b/drivers/pinctrl/sh-pfc/core.c
> @@ -803,8 +803,8 @@ static void sh_pfc_check_info(const struct sh_pfc_soc_info *info)
>  			       info->groups[i].name);
>  			sh_pfc_errors++;
>  		} else if (refcnts[i] > 1) {
> -			pr_err("%s: group %s referred by %u functions\n",
> -			       drvname, info->groups[i].name, refcnts[i]);
> +			pr_warn("%s: group %s referred by %u functions\n",
> +				drvname, info->groups[i].name, refcnts[i]);
>  			sh_pfc_warnings++;
>  		}
>  	}
> -- 
> 2.17.1
> 



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux