On Wed, Apr 24, 2019 at 3:59 PM Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: > The err_remove_chip block is too coarse, and may perform cleanup that > must not be done. E.g. if of_gpiochip_add() fails, of_gpiochip_remove() > is still called, causing: Good catch! Patch applied for fixes. Yours, Linus Walleij
Re: [PATCH v2] gpio: Fix gpiochip_add_data_with_key() error path
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2] gpio: Fix gpiochip_add_data_with_key() error path
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Thu, 25 Apr 2019 09:15:07 +0200
- In-reply-to: <20190424135933.25545-1-geert+renesas@glider.be>
- References: <20190424135933.25545-1-geert+renesas@glider.be>
- References:
- [PATCH v2] gpio: Fix gpiochip_add_data_with_key() error path
- From: Geert Uytterhoeven
- [PATCH v2] gpio: Fix gpiochip_add_data_with_key() error path
- Prev by Date: Re: [PATCH 5/5] MAINTAINERS: Add entry for BM1880 pinctrl
- Next by Date: Re: [PATCH 4/5] pinctrl: Add pinctrl support for BM1880 SoC
- Previous by thread: [PATCH v2] gpio: Fix gpiochip_add_data_with_key() error path
- Next by thread: Pinctrl DT for msm8998
- Index(es):
 |