On Mon, Apr 08, 2019 at 01:52:47PM +0200, Linus Walleij wrote: > On Tue, Apr 2, 2019 at 12:57 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > Indent entry values in the enum gpio_lookup_flags for better readability. > > > > No functional change. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > I am uncertain what to do with the series as there is some discussion > around patch 3/7, Andy can you collect the ACK from Hans and > resend the series as you want it to be merged? The idea as far as I understood Mika's concern is to use unsigned long for bitmaskedvalues, while keeping enum in place for definitions. For the gpiod_flags we may use enum always. I will do this and resend series with changes (I'll apply Ack wherever it's appropriated). -- With Best Regards, Andy Shevchenko