Re: [PATCH 1/2] tracing: stop making gpio tracing configurable

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello Enrico,

On Sat, Apr 06, 2019 at 07:20:37PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 05.04.19 21:46, Uwe Kleine-König wrote:
> > gpio tracing was made configurable in 4.4-rc1 (commit ddd70280bf0e
> > ("tracing: gpio: Add Kconfig option for enabling/disabling trace
> > events")). Since then it is the only event type that can be compiled
> > conditionally. Given that there is only little overhead I don't
> > understand the reasoning and I was annoyed more than once that gpio
> > events were not available without recompiling.
> 
> why 'default y' is not sufficient ?

I don't know. The kernels I stumbled over which had that disabled were
not configured by me. One public instance that disabled it (without
reasoning though) is commit 20c90af9ea6a. I assume it is done without
explicit justification in most of the cases. There are just too many
options you could care about. So reducing the number of options is a
good direction in my eyes.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |