Re: [PATCH v1 3/7] gpiolib: Change type of lflags in gpiod_hog() and gpiod_configure_flags()

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, Apr 04, 2019 at 11:16:19PM +0700, Linus Walleij wrote:
> On Thu, Apr 4, 2019 at 4:22 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:>
> > On Thu, Apr 04, 2019 at 11:52:20AM +0300, Mika Westerberg wrote:
> > > On Thu, Apr 04, 2019 at 11:37:35AM +0300, Andy Shevchenko wrote:
> > > > On Wed, Apr 03, 2019 at 09:36:24PM +0300, Mika Westerberg wrote:
> > > > > On Tue, Apr 02, 2019 at 01:57:32PM +0300, Andy Shevchenko wrote:

> Maybe it was stupid of me. We could change the enum gpio_lookup_flags
> to just
> #define GPIO_ACTIVE_HIGH 0
> #define GPIO_ACTIVE_LOW BIT(0)
> etc.
> 
> And then just have some unsigned long in struct gpiod_lookup.
> 
> What do you folks think makes most sense?

But it's not simple that, it also assumes persistent state.

-- 
With Best Regards,
Andy Shevchenko