On Wed, Apr 03, 2019 at 10:34:58AM +0200, Geert Uytterhoeven wrote: > On Wed, Jan 16, 2019 at 7:27 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > All controllers using GPIO descriptors can by definition > > support high CS connections, so just enforce this when > > registering an SPI controller. > But that is guaranteed to be true only for chip selects handled by a GPIO, > right? > Native chip selects may still not support SPI_CS_HIGH, depending > on the controller. > Before, the bad_bits check in spi_setup() would detect this, and return > an error. After, this will fail silently. > I agree configuring the system like this is a mistake by the integrator, > to be detected during integration testing. Yeah, it's kind of unfortunate that the flags are set at the controller level rather than at the chip select level as especially in this case it's likely that capabilities will diverge.
Attachment:
signature.asc
Description: PGP signature
