Re: [PATCH 4/8] pinctrl: sh-pfc: rcar-gen3: Remove HDMI CEC pins, groups, and functions

[Simon Horman <horms@xxxxxxxxxxxx>]

On Mon, Apr 01, 2019 at 12:58:13PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Apr 1, 2019 at 12:25 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Mon, Apr 01, 2019 at 12:14:26PM +0200, Simon Horman wrote:
> > > On Fri, Mar 29, 2019 at 04:29:38PM +0100, Geert Uytterhoeven wrote:
> > > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > > >
> > > > This reverts commit 7793ac664c5ebebdb021c4ec66ff9d174d58e98e.
> > > >
> > > > The HDMI CEC function is not supported by the R-Car Gen3 Hardware Manual
> > > > Rev 1.00. Therefore, delete the corresponding pin groups and functions,
> > > > and rename the HDMI[01]_CEC definitions to match their GPIO
> > > > functionality.
> > > >
> > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> > > > [geert: Squashed several commits]
> > >
> > > Ok, but it now does a lot more than revert
> > > 7793ac664c5ebebdb021c4ec66ff9d174d58e98e.
> > > That confused me a bit.
> 
> Sorry, I forgot to remove that line when squashing the commits.
> Will fix when queuing.

Great, thanks!

> > That notwithstanding,
> >
> > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>