Re: [PATCH] gpio: mockup: fix debugfs read

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

czw., 28 mar 2019 o 17:56 Linus Walleij <linus.walleij@xxxxxxxxxx> napisał(a):
>
> On Thu, Mar 28, 2019 at 5:47 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > czw., 28 mar 2019 o 17:38 Linus Walleij <linus.walleij@xxxxxxxxxx> napisał(a):
> > > On Fri, Mar 22, 2019 at 6:30 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > > >
> > > > The debugfs read callback must advance ppos or users using read() on
> > > > the file descriptor will never get the EOL. This wasn't spotted before
> > > > as I was using busybox cat for testing which uses sendfile() internally
> > > > and only noticed it now when switched to cat from coreutils.
> > > >
> > > > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > >
> > > Patch applied for fixes.
> > > Sorry for slow application, I was in no-wifi-land for some days.
> > >
> > > Yours,
> > > Linus Walleij
> >
> > Ugh, I was thinking about sending you a pull-request with this and a
> > subsequent fix this evening. Plus other fixes I have in my tree.
>
> Oh if it is easier for you do that, and I will drop this patch and just
> merge your PR as it arrives.
>
> Yours,
> Linus Walleij

Yes, let's do it.

Bart