On Mon, Mar 18, 2019 at 11:00:54PM +0300, Andy Shevchenko wrote: > The acpi_dev_get_first_match_name() is missing put_device() call > and thus keeping reference counting unbalanced. > > In order to fix the issue introduce a new helper to convert existing users > one-by-one to a better API. I think it makes more sense to convert all the existing users to this new API that does not leak, and remove the faulty function completely instead of marking it deprecated.
Re: [PATCH v2 1/2] ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 1/2] ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Thu, 28 Mar 2019 18:59:47 +0200
- In-reply-to: <20190318200055.84519-1-andriy.shevchenko@linux.intel.com>
- References: <20190318200055.84519-1-andriy.shevchenko@linux.intel.com>
- User-agent: Mutt/1.11.3 (2019-02-01)
- References:
- [PATCH v2 1/2] ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
- From: Andy Shevchenko
- [PATCH v2 1/2] ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
- Prev by Date: Re: [PATCH 1/3] gpio: of: Fix of_gpiochip_add() error path
- Next by Date: Re: [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free_hogs() usage
- Previous by thread: Re: [PATCH v2 1/2] ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
- Next by thread: [PATCH] pinctrl: berlin: Fix to avoid NULL pointer dereference
- Index(es):
 |