Re: [PATCH v3 03/10] pinctrl: sh-pfc: Add missing #include <linux/errno.h>

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, Mar 20, 2019 at 11:21:34AM +0100, Geert Uytterhoeven wrote:
> Source files using -Exxx error codes should include <linux/errno.h>.
> On ARM, this header file is included indirectly; on SuperH, it is not,
> leading to "error: ‘EINVAL’ undeclared" failures when enabling
> compile-testing later.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
> v3:
>   - No changes,
> 
> v2:
>   - New.
> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a77470.c    | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7790.c     | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7791.c     | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7794.c     | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7795.c     | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7796.c     | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a77965.c    | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a77970.c    | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a77980.c    | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a77990.c    | 1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a77995.c    | 1 +
>  12 files changed, 12 insertions(+)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77470.c b/drivers/pinctrl/sh-pfc/pfc-r8a77470.c
> index 4359aeb35dbdf8f3..83772abffaf81b66 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77470.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77470.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2018 Renesas Electronics Corp.
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "sh_pfc.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> index a84229cb8cd4c8a7..202638b9cb54ce5a 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> @@ -8,6 +8,7 @@
>   * Copyright (C) 2012  Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
>  #include <linux/sys_soc.h>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> index d8b13d4e9bbff7cb..d21a520695db1ae4 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -6,6 +6,7 @@
>   * Copyright (C) 2014-2017 Cogent Embedded, Inc.
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "sh_pfc.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7794.c b/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> index 958a5f714c93d967..d24ba71649a10888 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> @@ -7,6 +7,7 @@
>   * Copyright (C) 2015-2017 Cogent Embedded, Inc. <source@xxxxxxxxxxxxxxxxxx>
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  #include <linux/sys_soc.h>
>  
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> index 0ef7ada08316fa34..52a0fa8abfcca2bd 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2015-2017  Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "core.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> index 1a987dfea46f897a..6400e6304daf25e9 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2015-2017 Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  #include <linux/sys_soc.h>
>  
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> index a99c519e05a01f23..bb1255b9bc24241e 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
> @@ -11,6 +11,7 @@
>   * Copyright (C) 2015  Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "core.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> index 820b74ca9d10236b..c656d26e51503fe5 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
> @@ -12,6 +12,7 @@
>   * Copyright (C) 2015  Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "core.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77970.c b/drivers/pinctrl/sh-pfc/pfc-r8a77970.c
> index f5868f5e40189441..37d0c1f10901704e 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77970.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77970.c
> @@ -12,6 +12,7 @@
>   * Copyright (C) 2015  Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
>  
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77980.c b/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
> index 376e689c737821b5..42c73913b5c7088c 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
> @@ -12,6 +12,7 @@
>   * Copyright (C) 2015 Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
>  
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
> index 1a8d1ae896c0b0f5..10aa52eb4e32e467 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
> @@ -11,6 +11,7 @@
>   * Copyright (C) 2016-2017 Renesas Electronics Corp.
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "core.h"
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
> index 0acdfb8bf0777b50..110671d4626c541c 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
> @@ -11,6 +11,7 @@
>   * Copyright (C) 2015  Renesas Electronics Corporation
>   */
>  
> +#include <linux/errno.h>
>  #include <linux/kernel.h>
>  
>  #include "core.h"
> -- 
> 2.17.1
>