Re: [RESEND PATCH v6 03/11] dt-bindings: leds: add DT bindings for max77650

[Bartosz Golaszewski <brgl@xxxxxxxx>]

pt., 22 mar 2019 o 10:02 Pavel Machek <pavel@xxxxxx> napisał(a):
>
> On Mon 2019-03-18 18:40:32, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > Add the DT binding document for the LEDs module of max77650.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Acked-by: Pavel Machek <pavel@xxxxxx>
>
> > +             led@0 {
> > +                     reg = <0>;
> > +                     label = "blue:usr0";
> > +             };
>
> I'd rather not see these "usrX" things... Does it have some kind of
> real function?

Not really. In the design we're using it for, it's unused and on the
development kit from MAXIM it's simple three colored leds.

Bart

>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html