On 12.03.19 10:17, Ben Dooks wrote: > On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote: >> don't need the temporary variable "dev", directly use &pdev->dev >> >> Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx> > > This is quite usual to do, and I like it as it saves typing. > Personally I would say don't bother with this change. hmm, both approaches have their valid arguments. I'm not particularily biased to one or another ay, but I'd prefer having it consistent everywhere. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287