On 01.03.19 15:27, Axel Lin wrote: > Current amd_fch_gpio_direction_output implementation ignores the value > argument, fix it so direction_output will set proper output level. Oh, thanks ... how could I have missed that. Haven't had the time to test it yet (been too busy w/ embedded world, last week and now need a few days off). But looks good to me, so add Reviewed-By me. @Linus: are you okay w/ taking this patch ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287