Re: [PATCH] gpio: tegra: Fix offset of pinctrl calls

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Feb 19, 2019 at 10:24 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote:

> This is formally a correct patch, but none of Tegra's upstream pinctrl drivers implement
> gpio_set_direction() and chip->base=0. Hence I'm not sure whether this all is really
> necessary..

The API wants a valid global GPIO number, the current code is confusing since it
sends random numbers (offsets) instead.

> or maybe you're going to implement the gpio_set_direction()?

No but since nVidia has fixed it in their outoftree codebase and it is formally
correct I don't see why we shouldn't just fix it. It may confuse someone.

Yours,
Linus Walleij