Re: [PATCH 1/2] drivers: provide devm_platform_ioremap_resource()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

śr., 20 lut 2019 o 10:57 Linus Walleij <linus.walleij@xxxxxxxxxx> napisał(a):
>
> On Fri, Feb 15, 2019 at 4:25 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > There are currently 1200+ instances of using platform_get_resource()
> > and devm_ioremap_resource() together in the kernel tree.
> >
> > This patch wraps these two calls in a single helper. Thanks to that
> > we don't have to declare a local variable for struct resource * and can
> > omit the redundant argument for resource type. We also have one
> > function call less.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> This makes a lot of sense. I think Andy can confirm the value, he
> knows a lot about good helpers.
>
> I'd need Greg's ACK on this before merging through GPIO.
>
> Can we make a script or coccinelle thing to fix them all when this
> is applied?
>

Yes, it's on my list (and also a chance to learn first hand how to
work with coccinelle), but we first need this function upstream. I'll
resend a v2 with the EXPORT_SYMBOL fixed.

Bart