Re: [PATCH] gpio: of: Apply regulator-gpio quirk only to enable-gpios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 19, 2019 at 5:30 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote:

> Handling broken DTs only adds to the complexity, but I think this cannot
> be helped, since those DTs can be stored in some ROM.

I agree, but if the broken DT needs to be supported going forward
I would like it to be quite explicit, so that the code down in
gpiolib-of.c does this:

/*
 * Comment about this machine
 */
if (of_machine_is_compatible("nvidia,problematic-board") {
   /* Quirk for this specific DT for this machine*/
}

This makes the standard behavior clear and avoids the risk
of applying hairy machine-specific quirks to any other machine,
but even more importantly it makes it easy for people reading
the code to see what is going on and why.

Yours,
Linus Walleij



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux