Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2

[Lubomir Rintel <lkundrak@xxxxx>]

On Thu, 2019-02-14 at 09:13 +0100, Linus Walleij wrote:
> On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@xxxxx> wrote:
> 
> > Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> > See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> > PXA3xx")
> > 
> > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> 
> Patch applied for fixes.
> 
> Should this even go into stable?

I would tend to think it should.

This caused a regression for MMP2 platforms that don't use a pinctrl
driver, and none of them do.

On the other hand it went unnoticed since v4.5.

I've seen stable maintainers pick up fixes even when stable@ wasn't
Cc'd. I guess they apply some heuristics and perhaps look at Fixes:
tags to identify bugfixes?

> Yours,
> Linus Walleij

Lubo