Hi Linus, On Fri, Feb 8, 2019 at 10:27 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > Hi Sugaya, > > thank you for the patch! > > Since Masahiro has previously added the Uniphier pin control driver > I would like him to provide a review of this patch, if possible. I also > want to make sure that the hardware is different enough from the > existing Uniphier pin control so that it really needs a new > driver, else I suppose it should be refactored to be part of > the pinctrl/uniphier drivers (we can of course rename it > pinctrl/socionext if only naming is an issue). Milbeaut and UniPhier are totally different platforms, so no code is shareable. At most, they could share the directory, drivers/pinctrl/socionext/, if you like. I know you prefer grouping by SoC-family instead of by vendor-name as you stated in the "Moving ARM dts files" discussion. -- Best Regards Masahiro Yamada