Re: [PATCH v1 04/10] gpio: crystalcove: Sort headers alphabetically

sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> · Tue, 5 Feb 2019 10:59:32 -0800

On 2/5/19 5:38 AM, Andy Shevchenko wrote:
Sort header block alphabetically for easy maintenance.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>

---
  drivers/gpio/gpio-crystalcove.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 3c39d1b6c3ad..c73e7c285636 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -15,14 +15,14 @@
   * Author: Yang, Bin <bin.yang@xxxxxxxxx>
   */
  
+#include <linux/bitops.h>
+#include <linux/gpio/driver.h>
  #include <linux/interrupt.h>
+#include <linux/mfd/intel_soc_pmic.h>
  #include <linux/module.h>
  #include <linux/platform_device.h>
-#include <linux/gpio/driver.h>
-#include <linux/seq_file.h>
-#include <linux/bitops.h>
  #include <linux/regmap.h>
-#include <linux/mfd/intel_soc_pmic.h>
+#include <linux/seq_file.h>
  
  #define CRYSTALCOVE_GPIO_NUM	16
  #define CRYSTALCOVE_VGPIO_NUM	95

--
Sathyanarayanan Kuppuswamy
Linux kernel developer







