Hi Kwin, On Wed, Jan 16, 2019 at 3:30 PM Wang, Kuiying <kuiying.wang@xxxxxxxxx> wrote: > Hi Joel, > Do agree to use proposal #1? (extend "passthrough" to the "direction" property of gpio, use "value" to control it be disabled/enabled.) > > All, > Any other comments? I think you maybe misunderstood my previous mail, or I misunderstood yours :) Make sure that passthrough mode is set up in the .set_config() callback, nothing else. Do not change the signatures of the direction functions or set_value() functions in gpiolib. But maybe you are talking about implementation details in the specific GPIO driver for Aspeed? Then I just missed that part, sorry. Yours, Linus Walleij