Re: [PATCH] gpiolib: check if irqchip already has the irq hook replacements

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Linus,

On Mon, Jan 21, 2019 at 1:13 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Jan 21, 2019 at 11:37 AM Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
> > Looks like there may still be several drivers that would trigger this.
> > On next-20190121:
> (...)
> > Not all of them may have multiple instances, though.
> > I saw patches for some of them.
>
> If I read the code right the warning will not be printed until
> you try to register the same irqchip twice, on the second
> registration.
>
> If you just register one chip which is static const, nothing
> happens.

Correct.

> I think we have fixed most ... but I need to fix some more
> still.

Indeed.

There are a few more which are i2c GPIO expanders, which can easily
have multiple instances.

Searching in the mailing list archives for the printed message revealed
a vf610 log showing 4 instances.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds