On Fri, Jan 18, 2019 at 07:13:38PM +0100, Bartosz Golaszewski wrote: > pt., 18 sty 2019 o 19:01 Mark Brown <broonie@xxxxxxxxxx> napisał(a): > > > +++ b/drivers/regulator/max77650-regulator.c > > > @@ -0,0 +1,537 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2018 BayLibre SAS > > > + * Author: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > Please make the entire header C++ style so it looks more intentional. > Seems like there are more files in the kernel source using the mixed > comment style for the SPDX identifier and I also prefer it over C++ > only. Would you mind if it stayed that way? I'd prefer to change. > > You don't need to do this, the core will do it for you (it will actually > > still do it even with the above, it'll only fall back to using > > config->init_data if it's own lookup fails). > I added this loop specifically because the core would not pick up the > init data from DT. What did I miss (some specific variable to assign)? > I just noticed some other drivers do the same and thought it's the > right thing to do. You should set regulators_node and of_match, see regulator_of_get_init_node().
Attachment:
signature.asc
Description: PGP signature
