Hi, Commit f4caa6ee736fa8a4 ("pinctrl: sh-pfc: r8a77990: Add support for pull-up only pins") added an explicit check for the GP6_9 pin on R-Car E3, which supports pull-up, but not pull-down. However, I had forgotten this limitation can be expressed better by dropping the SH_PFC_PIN_CFG_PULL_DOWN flag from the GPIO description, as it includes returning an error to the caller when trying to configure the pin for pull-down. Hence this patch series drops the SH_PFC_PIN_CFG_PULL_DOWN flag, and reverts the previous solution. This has been tested on by adding the following to the pfc node in arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts: pinctrl-0 = <&test6_9>; pinctrl-names = "default"; test6_9: test6_9 { pins = "GP_6_9"; bias-pull-down; }; I plan to queue this up in sh-pfc-for-v5.1. Thanks! Geert Uytterhoeven (2): pinctrl: sh-pfc: r8a77990: GP6_9 does not have pull-down capability Revert "pinctrl: sh-pfc: r8a77990: Add support for pull-up only pins" drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 34 ++++++++++++--------------- 1 file changed, 15 insertions(+), 19 deletions(-) -- 2.17.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds