Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Marek Vasut <marek.vasut@xxxxxxxxx>]

On 1/11/19 2:50 AM, weiyongjun (A) wrote:
>> From: Marek Vasut [mailto:marek.vasut@xxxxxxxxx]
>> Sent: Thursday, January 10, 2019 10:07 PM
>> To: weiyongjun (A) <weiyongjun1@xxxxxxxxxx>; Linus Walleij
>> <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski
>> <bgolaszewski@xxxxxxxxxxxx>
>> Cc: linux-gpio@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH -next] gpio: pca953x: Make symbol
>> 'pca953x_i2c_regmap' static
>>
>> On 1/10/19 3:07 PM, Wei Yongjun wrote:
>>> Fixes the following sparse warning:
>>>
>>> drivers/gpio/gpio-pca953x.c:292:28: warning:
>>>  symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
>>>
>>> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
>>> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>>
>> Nice, thanks.
>> Reviewed-by: Marek Vasut <marex@xxxxxxx>
>>
>> For future reference, how did you run sparse to detect this ?
> 
> 
> I have a script which run sparse everyday on each changed file
> of linux-next.git tree. So most of this issues can be detected.

Can you share that script ? I'm sure others can benefit from that too.

-- 
Best regards,
Marek Vasut