Re: [PATCH v2] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Dec 31, 2018 at 9:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

> __acpi_gpio_update_gpiod_flags purpose is to make the gpiod_flags used
> when requesting a GPIO match the restrictions from the ACPI resource,
> as stored in acpi_gpio_info.flags.
>
> But acpi_gpio_info.flags only contains direction info, and the
> requester may have passed in special non-direction flags like
> GPIOD_FLAGS_BIT_NONEXCLUSIVE, which we currently clobber.
>
> This commit modifies __acpi_gpio_update_gpiod_flags to preserve these
> special flags, so that a requested of an ACPI GPIO can e.g. pass
> GPIOD_FLAGS_BIT_NONEXCLUSIV and have it work as intended.
>
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Patch applied for next for now.

Is this a fix that need to go into the -rcN?

In that case, is there an appropriate Fixes: tag?

Yours,
Linus Walleij