On Sun, Dec 30, 2018 at 06:29:44PM +0100, Hans de Goede wrote: > __acpi_gpio_update_gpiod_flags purpose is to make the gpiod_flags used > when requesting a GPIO match the restrictions from the ACPI resource, > as stored in acpi_gpio_info.flags. > > But acpi_gpio_info.flags only contains direction info, and the > requester may have passed in special non-direction flags like > GPIOD_FLAGS_BIT_NONEXCLUSIVE, which we currently clobber. > > This commit modifies __acpi_gpio_update_gpiod_flags to preserve these > special flags, so that a requested of an ACPI GPIO can e.g. pass > GPIOD_FLAGS_BIT_NONEXCLUSIV and have it work as intended. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Re: [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Mon, 31 Dec 2018 11:34:08 +0200
- In-reply-to: <20181230172944.17758-1-hdegoede@redhat.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20181230172944.17758-1-hdegoede@redhat.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
- From: Hans de Goede
- [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
- Prev by Date: Re: [PATCH 0/3] qcom: spmi: add support for hierarchical IRQ chip
- Next by Date: [RFT][PATCH] gpio: sama5d2-piobu: Set proper output level for direction_output
- Previous by thread: [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
- Next by thread: Re: [PATCH] gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
- Index(es):
 |