Re: RFC: qcom spmi/ssbi-gpio hierarchical irqchip problems

[Brian Masney <masneyb@xxxxxxxxxxxxx>]

On Mon, Dec 17, 2018 at 02:00:14PM +0100, Linus Walleij wrote:
> On Mon, Dec 17, 2018 at 2:58 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:
> 
> > With this series, I see a long delay on startup and the following errors
> > in the console log:
> >
> > [    1.374586] spmi spmi-0: pmic_arb_wait_for_done: transaction denied (0x5)
> > [    1.393541] qcom-spmi-iadc fc4cf000.spmi:pm8941@0:iadc@3600: conversion failed
> > [    1.393587] qcom-spmi-iadc fc4cf000.spmi:pm8941@0:iadc@3600: failed offset calibration
> > [    1.399681] spmi spmi-0: pmic_arb_wait_for_done: transaction denied (0x5)
> > [    1.407629] qcom-spmi-iadc: probe of fc4cf000.spmi:pm8941@0:iadc@3600 failed with error -110
> > [    1.414900] spmi spmi-0: pmic_arb_wait_for_done: transaction denied (0x5)
> > [    1.422949] spmi spmi-0: pmic_arb_wait_for_done: transaction denied (0x5)
> > [   41.433579] qcom-spmi-vadc fc4cf000.spmi:pm8941@0:vadc@3100: conversion failed
> > [   41.433626] qcom-spmi-vadc fc4cf000.spmi:pm8941@0:vadc@3100: measure reference points failed
> > [   41.439722] spmi spmi-0: pmic_arb_wait_for_done: transaction denied (0x5)
> > [   41.448296] qpnpint_spmi_write: 21 callbacks suppressed
> > [   41.448305] spmi spmi-0: failed irqchip transaction on d7
> >
> > I'm going to keep digging but I'm posting this to see if anyone has any
> > suggestions.
> 
> I don't think those are your errors. If you didn't have them before, it's
> probably a side-effect of the IRQ from the ADC starting to work.

I didn't have these errors before. I verified that interrupts from the
ADC were previously working according to /proc/interrupts. Here are the
relevant entries after system startup:

 98:          4          0  pmic_arb 51380274 Edge      spmi-vadc
 99:          3          0  pmic_arb 56623157 Edge      spmi-iadc

Reading from the various sysfs files in iio:device[01] causes more
interrupts to be fired.

 98:         29          0  pmic_arb 51380274 Edge      spmi-vadc
 99:          8          0  pmic_arb 56623157 Edge      spmi-iadc

Interrupts from the volume keys were previously delivered to gpio-keys
when I pressed the buttons. 

 54:          2          0  pmic_arb 202375255 Edge      volume_up
 55:         10          0  pmic_arb 203423832 Edge      volume_down

The interrupts stopped working with the IRQ hierarchy patch series that
I attached to my last email. I haven't had time to dig into this further
this week but I should have some time this weekend.

Brian