Re: [PATCH pinctrl] pinctrl: armada-37xx: Correct mpp definitions

[Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>]

Hi Marek,
 
 On dim., déc. 16 2018, Marek Behun <marek.behun@xxxxxx> wrote:

> On Sun, 16 Dec 2018 10:46:30 +0100
> Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote:
>
>> It seemms that this patch was never applied however it fixes some
>> issues but in a wrong way and also it is also not complete.
>
> Hi Gregory,
> what do you mean by "in a wrong way"?

I think you missed the second part of the email, I add it back:

> @@ -195,8 +195,9 @@ static struct armada_37xx_pin_group armada_37xx_sb_groups[] = {
>  	PIN_GRP_GPIO("usb2_drvvbus1", 1, 1, BIT(1), "drvbus"),
>  	PIN_GRP_GPIO("sdio_sb", 24, 6, BIT(2), "sdio"),
>  	PIN_GRP_GPIO("rgmii", 6, 12, BIT(3), "mii"),
> -	PIN_GRP_GPIO("pcie1", 3, 2, BIT(4), "pcie"),
> -	PIN_GRP_GPIO("ptp", 20, 3, BIT(5), "ptp"),
> +	PIN_GRP_GPIO("smi", 18, 2, BIT(4), "smi"),
> +	PIN_GRP_GPIO("pcie1", 3, 2, BIT(5) | BIT(9), "pcie"),

Actually those 2 pins are no more a group but can be configured
individually.

It should be:
	PIN_GRP_GPIO("pcie1", 3, 1, BIT(5), "pcie"),
	PIN_GRP_GPIO("pcie1_clkreq", 4, 1, BIT(9), "pcie"),



Gregory

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com