Re: [PATCH] ARM: omap1: Fix new user of gpiochip_request_own_desc()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sun, Dec 16, 2018 at 11:04 AM Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx> wrote:

> There is one more AMS Delta related file where gpiod_request_own_desc() is
> called and the same fix is needed: arch/arm/mach-omap1/ams-delta-fiq.c.

I handled that in the original patch actually! :)

>  With
> that fixed, you can add my
>
>         Reviewed-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxx>

Thanks!

> >       gpiod = gpiochip_request_own_desc(chip, AMS_DELTA_GPIO_PIN_MODEM_IRQ,
> > -                                       "modem_irq");
> > +                                       "modem_irq", 0);
>
> Both here and in ams-delta-fiq.c as well, gpiod_direction_input() is called
> soon after. That could be dropped if GPIOD_FLAGS_BIT_DIR_SET was used instead
> of 0.  I can take care of that and prepare a follow up patch if you prefer
> this one being kept as minimal as possible.

It's better if you send a separate patch as follow-up because
you know what you are doing, in contrast to me ... I just change
the function signature because I have to, it is always super scary
to patch other people's board files.

Yours,
Linus Walleij