Re: [PATCH] gpio: gpio-omap: Revert deferred wakeup quirk handling for regressions

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Dec 7, 2018 at 8:08 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:

> Commit ec0daae685b2 ("gpio: omap: Add level wakeup handling for omap4
> based SoCs") attempted to fix omap4 GPIO wakeup handling as it was
> blocking deeper SoC idle states. However this caused a regression for
> GPIOs during runtime having over second long latencies for Ethernet
> GPIO interrupt as reportedy by Russell King <rmk+kernel@xxxxxxxxxxxxxxx>.
>
> Let's fix this issue by doing a partial revert of the breaking commit.
> We still want to keep the quirk handling around as it is also used for
> OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER.
>
> The real fix for omap4 GPIO wakeup handling involves fixes for
> omap_set_gpio_trigger() and omap_gpio_unmask_irq() and will be posted
> separately. And we must keep the wakeup bit enabled during runtime
> because of module doing clock autogating with autoidle configured.
>
> Reported-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Fixes: ec0daae685b2 ("gpio: omap: Add level wakeup handling for omap4
> based SoCs")
> Cc: Aaro Koskinen <aaro.koskinen@xxxxxx>
> Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>
> Cc: Keerthy <j-keerthy@xxxxxx>
> Cc: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Cc: Tero Kristo <t-kristo@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij