Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option

[Andrew Jeffery <andrew@xxxxxxxx>]

On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> Clang does not support this option:
> 
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Acked-by: Andrew Jeffery <andrew@xxxxxxxx>

> ---
>  drivers/pinctrl/aspeed/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
> index 191ed0fc1804..790b406aae19 100644
> --- a/drivers/pinctrl/aspeed/Makefile
> +++ b/drivers/pinctrl/aspeed/Makefile
> @@ -1,6 +1,6 @@
>  # Aspeed pinctrl support
>  
> -ccflags-y += -Woverride-init
> +ccflags-y += $(call cc-option,-Woverride-init)
>  obj-$(CONFIG_PINCTRL_ASPEED)	+= pinctrl-aspeed.o
>  obj-$(CONFIG_PINCTRL_ASPEED_G4)	+= pinctrl-aspeed-g4.o
>  obj-$(CONFIG_PINCTRL_ASPEED_G5)	+= pinctrl-aspeed-g5.o
> -- 
> 2.20.0
>