Re: [PATCH v2 2/2] gpiolib-acpi: Remove unnecessary WARN_ON from acpi_gpiochip_free_interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 07-12-18 11:04, Linus Walleij wrote:
On Wed, Nov 28, 2018 at 5:58 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:

acpi_gpiochip_alloc_event only continues allocating an event and adding
it to the list if gpiochip_request_own_desc does not return an error.
So events with an error desc are never placed on the events list and this
check is really not necessary.

Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

This doesn't apply cleanly other than on top of the patch
sent for fixes.

So I include it with the fixes. No big deal. I think.

Yes, that is fine. Thank you.

Regards,

Hans




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux