Hi, On Thu, Dec 06, 2018 at 11:28:21PM +0800, Chen-Yu Tsai wrote: > On Thu, Dec 6, 2018 at 10:02 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > The main interogation I have currently is whether we should always try to > > get the regulator for the current branch, or if we should restrict it to > > the one available on the SoCs. > > Not sure what you mean here, but we should probably just list the actual > names. The A20 for example doesn't have a VCC-PB regulator, so do we want to try to grab it if we request a PB* pin, or should we just know that somehow and not do it? > For pre-A20 SoCs (A10/A10s/A13), they aren't even named VCC-Px. Instead > they are named after the primary function of the pin bank, such as > VCC-CARD, VCC-NAND, VCC-CSI0, VCC-CSI1. I'd really prefer to stick to vcc-pX, that's pretty obvious even for those older SoCs, and we can maintain some consistency that way. > For pin banks that don't have per-bank power inputs, you should fall back > to VCC-IO, or VCC-RTC in the case of the PL pins. > > So here's the rub: On A33 and later SoCs that are paired with a PMIC, VCC-PL > or VCC-RTC is powered by the RTC regulator of the PMIC, which only gets > registered when the PMIC regulator driver is probed, which needs the RSB > controller, which needs the pin controller and the PL pins... I haven't seen any VCC-P* on the A33, do you have a reference? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature